Add a benchmark to test fetching of many relationships. #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #49 will create unknown performance changesComparing Summary
Benchmarks breakdown
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #49 +/- ##
==========================================
+ Coverage 77.37% 82.13% +4.75%
==========================================
Files 10 10
Lines 725 907 +182
Branches 108 125 +17
==========================================
+ Hits 561 745 +184
+ Misses 135 129 -6
- Partials 29 33 +4 |
…sync. I left a note in the loader's __init__, but to duplicate that here: Making blocking database calls from within an async function (the resolver) has catastrophic performance implications. Not only will all resolvers be effectively serialized, any other coroutines waiting on the event loop (e.g. concurrent requests in a web server), will be blocked as well, grinding your entire service to a halt. There's no reason for us to support a foot bazooka, hence the deprecation.
This functions as a baseline, to confirm a bug that I believe I spotted which effectively serializes resolution of each relationship.
mattalbr
force-pushed
the
benchmark_relationships
branch
from
f4719fa to
eb84326
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This functions as a baseline, to confirm a bug that I believe I spotted which effectively serializes resolution of each relationship.